[Do not merge yet] Support SHA-256 git repos with libgit2 experimental API #14526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fetching
Ericson2314
commented
Nov 9, 2025
packaging/dependencies.nix
Outdated
| ]; | ||
|
|
||
| postInstall = (attrs.postInstall or "") + '' | ||
| substituteInPlace $(find $dev/include -type f) --replace-quiet '#include "git2/' '#include "git2-experimental/' |
Member
Author
There was a problem hiding this comment.
@ethomson I don't know if this is Nixpkg's fault, or upstream libgit2's fault, but I noticed that may of the header still refer to git2/ despite the install location changing to git2-experimental.
I did this quick hack to stay unblocked and git on to the more interesting bits, bu it would be good to get that fixed upstream if it is indeed an upstream issue.
Ericson2314
force-pushed
the
libgit2-256
branch
from
d2f8b95 to
7ede34d
Compare
Just patch the package for now, but we should make Nixpkgs provide what we need (whether that the experimental variant, or a 2.x release with the new API made non-experimental) before releasing this change.
This experimental interface is likely to become stable with libgit2 2.0.
Note that for Nix-native information we should *not* do length tricks, but instead always rely on an explicit algorithm. This hack should be only for foreign hash literals.
Ericson2314
force-pushed
the
libgit2-256
branch
from
7ede34d to
1560614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9980
Context
Upstream PR asked us ot help break chicken and egg problem by doing this here libgit2/libgit2#7149 (comment)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.